akka/akka-core

expectNextN in javadsl.TestSink returns a Scala collection.

Open

#27,312 opened on Jul 9, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Scala (3,547 forks)batch import
1 - triagedhelp wantedt:javat:testing

Repository metrics

Stars
 (13,277 stars)
PR merge metrics
 (Avg merge 8d 19h) (10 merged PRs in 30d)

Description

I have a java project that is using:

import akka.stream.testkit.javadsl.TestSink;

I then do something like:

sink.runWith(TestSink.probe(system), materializer)
  .request(100)
  .expectNextN(100)

I would have expected to receive a Java collection of elements. However I don't. I receive a Scala Seq. Given this is the javadsl version of the TestSink, I think it should probably return a Java collection, rather than a Scala collection.

Contributor guide

Research direction
Examine the javadsl.TestSink.expectNextN method signature and implementation; the return type should be changed from scala.collection.Seq to java.util.List or similar Java collection. Ensure backward compatibility if needed.
Tech stack
scalajava
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScala
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65