akka/akka-core

expectNextN in javadsl.TestSink returns a Scala collection.

Open

#27,312 opened on Jul 9, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Scala (13,277 stars) (3,547 forks)batch import
1 - triagedhelp wantedt:javat:testing

Description

I have a java project that is using:

import akka.stream.testkit.javadsl.TestSink;

I then do something like:

sink.runWith(TestSink.probe(system), materializer)
  .request(100)
  .expectNextN(100)

I would have expected to receive a Java collection of elements. However I don't. I receive a Scala Seq. Given this is the javadsl version of the TestSink, I think it should probably return a Java collection, rather than a Scala collection.

Contributor guide

Tech stack
javascala
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScalaAkka Streams basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the source file for javadsl.TestSink, specifically the expectNextN method. The return type is currently Scala's Seq; change it to return java.util.List or a Java friendly collection type. Ensure that the underlying implementation converts the Scala Seq to a Java collection. Check related test files for expected behavior. Comment #2 may have additional details.
expectNextN in javadsl.TestSink returns a Scala collection. · akka/akka-core#27312 | Good First Issue