akka/akka-core

improve JavaDurationConverters

Open

#24,805 opened on Mar 28, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Scala (3,547 forks)batch import
1 - triagedhelp wantedt:core

Repository metrics

Stars
 (13,277 stars)
PR merge metrics
 (Avg merge 8d 19h) (10 merged PRs in 30d)

Description

asScala should return FiniteDuration

asJava should be for FiniteDuration, because toNanos will throw for anything else

Contributor guide

Research direction
Examine the JavaDurationConverters source to change `asScala` return type to `FiniteDuration` and ensure `asJava` only accepts `FiniteDuration`.
Tech stack
scala
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ScalaJava interop
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70