akka/akka-core

resizer.enabled is confusing and undocumented

Open

#24,284 opened on Jan 11, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Scala (13,277 stars) (3,547 forks)batch import
1 - triagedhelp wanted

Description

I expected akka.actor.deployment.router.resizer.enabled = off would disable the resizer, but it doesn't appear to. I have to remove the entire section to disable. (Granted, it says so in the docs). But what is "enabled" for then?

from ktoso: some legacy reasons i guess

It's a bit confusing to have enabled = on (without any comments) in reference.conf since it suggests that you could use it to turn the resizer on/off.

If it doesn't do anything then the flag should probably be removed, or it should actually work. But barring that, a comment in reference.conf to clarify would help remove any confusion.

Also optimal-size-exploring-resizer.

Contributor guide

Tech stack
scala
Domain
backenddocumentation
Issue type
documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue points to the reference.conf file in the Akka codebase where the 'resizer.enabled' configuration is defined. The fix involves adding a comment explaining that setting this flag to 'off' does not actually disable the resizer; instead, removing the section is required. The maintainer 'ktoso' indicated it's legacy. The optimal size exploring resizer also needs similar clarification. The solution is documentation only, no code change needed.