akka/akka-core

Source.combine instance method sould require only one argument

Open

#22,452 opened on Mar 4, 2017

View on GitHub
 (11 comments) (1 reaction) (0 assignees)Scala (3,547 forks)batch import
1 - triagedhelp wantedt:stream

Repository metrics

Stars
 (13,277 stars)
PR merge metrics
 (Avg merge 17h 35m) (11 merged PRs in 30d)

Description

It is currently a copy of the static combine and should either be removed or changed so that it requires a minimum of one argument and adds itself as the first input of the resulting Source.

Contributor guide

Research direction
Examine the Source class in akka stream to locate the instance combine method. Understand the current behavior (copied from static combine). Modify it to require at least one argument and add itself as the first input. Review the existing tests for combine to ensure changes are consistent. Also check the comments in the issue for any additional context or constraints.
Tech stack
scala
Domain
apibackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Scala basicsAkka Streams API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60