akka/akka-core

Pruning in DistributedPubSub is not covered by tests and in the documentation

Open

#21,100 opened on Aug 2, 2016

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Scala (3,547 forks)batch import
1 - triagedhelp wantedt:cluster-tools

Repository metrics

Stars
 (13,277 stars)
PR merge metrics
 (Avg merge 8d 19h) (10 merged PRs in 30d)

Description

I've tried to understand, how removed-time-to-live works in DistributedPub sub, but I haven't found any references in the docs. Also the method prune() https://github.com/akka/akka/blob/master/akka-cluster-tools/src/main/scala/akka/cluster/pubsub/DistributedPubSubMediator.scala#L812 is not covered neither by unittests nor by multi-node tests. Also you have implemented a trait "PerGroupingBuffer" in 2.4.2, but his trait also is not covered by tests. It would be good to have tests for the whole PR: https://github.com/akka/akka/pull/19154

Contributor guide

Research direction
Examine the prune() method in DistributedPubSubMediator.scala and the PerGroupingBuffer trait, then write unit tests and multi node tests to cover the pruning functionality and update documentation to explain removed time to live.
Tech stack
scala
Domain
backendtesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ScalaAkkatesting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60