akka/akka-core

Inconsistent signature of Flow#recoverWithRetries

Open

#20,606 opened on May 24, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Scala (3,547 forks)batch import
1 - triagedhelp wantedt:stream

Repository metrics

Stars
 (13,277 stars)
PR merge metrics
 (Avg merge 8d 19h) (10 merged PRs in 30d)

Description

We discussed this issue at Gitter.

It feels like recovery function should be inside separate argument group, i.e.

recoverWithRetries(42) {
  case _ => Source.empty
}

looks much better than

recoverWithRetries(42, {
  case _ => Source.empty
})

Contributor guide

Research direction
Identify all call sites of Flow.recoverWithRetries and update them to use the new curried syntax.
Tech stack
scala
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Scala
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65