akka/akka-core

Fold inHandlers, outHandlers into GraphLogic to avoid redundat object creation

Open

#19,752 opened on Feb 11, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Scala (3,547 forks)batch import
1 - triagedhelp wantedt:stream

Repository metrics

Stars
 (13,277 stars)
PR merge metrics
 (Avg merge 8d 19h) (10 merged PRs in 30d)

Description

Example can be simple stage like LastOptionStage where GraphStageLogic can have onPush, onUpstreamFinish methods and then handler can be added like: setHandler(in,this).

Base on @rkuhn comment: https://github.com/akka/akka/pull/19634/files#r52571768

Contributor guide

Research direction
Investigate the GraphStageLogic class to understand how inHandlers and outHandlers are created and used. Find the redundant object creation and propose folding them into GraphLogic by overriding methods like onPush and onUpstreamFinish directly.
Tech stack
scala
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
ScalaAkka Streams
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55