akka/akka-core

Fold inHandlers, outHandlers into GraphLogic to avoid redundat object creation

Open

#19,752 opened on Feb 11, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Scala (13,277 stars) (3,547 forks)batch import
1 - triagedhelp wantedt:stream

Description

Example can be simple stage like LastOptionStage where GraphStageLogic can have onPush, onUpstreamFinish methods and then handler can be added like: setHandler(in,this).

Base on @rkuhn comment: https://github.com/akka/akka/pull/19634/files#r52571768

Contributor guide

Tech stack
scala
Domain
backendperformance
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of Akka StreamsFamiliarity with GraphStageLogicScala programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the comment on PR #19634 (linked in the issue) to understand the proposed approach. Examine the current implementation of GraphStageLogic and LastOptionStage in the Akka codebase. Files likely include classes related to GraphStageLogic and handler management. Determine if folding handlers reduces object creation and implement accordingly.
Fold inHandlers, outHandlers into GraphLogic to avoid redundat object creation · akka/akka-core#19752 | Good First Issue