akka/akka-core

ShardRegion - use counter instead of calculating size using foldLeft

Open

#19,191 opened on Dec 15, 2015

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Scala (3,547 forks)batch import
1 - triagedhelp wantedt:cluster-shardingt:cluster-tools

Repository metrics

Stars
 (13,277 stars)
PR merge metrics
 (Avg merge 8d 19h) (10 merged PRs in 30d)

Description

As mentioned in #19154 - instead of using totalBufferSize calculated by foldLefting shardBuffers everytime it is possible to add simple integer counter to ShardRegion actor to improve performance.

Contributor guide

Research direction
Add an integer counter to ShardRegion actor to avoid calculating totalBufferSize via foldLeft on shardBuffers. Update increment/decrement logic appropriately.
Tech stack
java
Domain
backend
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitScala
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60