akiran/react-slick

Bug: dots and slideToScroll -1 options crush slider

Open

#1572 opened on Jun 13, 2019

View on GitHub
 (9 comments) (0 reactions) (0 assignees)JavaScript (11,386 stars) (2,109 forks)batch import
good first issue

Description

When we use slider options together it crashes: https://codesandbox.io/s/react-slick-playground-82tjh

Contributor guide

Tech stack
reactjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Reproduce the crash using the provided CodeSandbox. Examine the react slick source code, particularly the interaction between 'dots' and 'slideToScroll' options. Focus on the state management for current slide and dot rendering. Investigate if 'slideToScroll: 1' is intended to scroll one slide at a time and how it conflicts with dot navigation.