akiran/react-slick

slick-cloned slides visible if slidesToDisplay > slide count

Open

#1569 opened on Jun 11, 2019

View on GitHub
 (4 comments) (2 reactions) (0 assignees)JavaScript (11,386 stars) (2,109 forks)batch import
good first issue

Description

In recent versions, if slidesToShow is set to a value greater than the number of slides, all of the slick-cloned slides will be visible.

To replicate: in the PlayGround (https://codesandbox.io/s/ppwkk5l6xx) update the settings:

var settings = {
      dots: true,
      slidesToShow: 5
    };

Version 0.21.0 does not behave this way. With version 0.21.0 if the slidesToShow is greater than the number of slides, it does not create the slick-cloned slides.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic ReactUnderstanding of react slick
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the logic that generates slick cloned slides in react slick, specifically in the component that handles slidesToShow. Compare current behavior with version 0.21.0 where the clones were not created when slidesToShow exceeds slide count. The relevant code is likely in the initialization or rendering of slides. Check for a condition that should prevent cloning when slide count is less than slidesToShow.