akiran/react-slick

slick-cloned slides visible if slidesToDisplay > slide count

Open

#1,569 opened on Jun 11, 2019

View on GitHub
 (4 comments) (2 reactions) (0 assignees)JavaScript (2,109 forks)batch import
good first issue

Repository metrics

Stars
 (11,386 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In recent versions, if slidesToShow is set to a value greater than the number of slides, all of the slick-cloned slides will be visible.

To replicate: in the PlayGround (https://codesandbox.io/s/ppwkk5l6xx) update the settings:

var settings = {
      dots: true,
      slidesToShow: 5
    };

Version 0.21.0 does not behave this way. With version 0.21.0 if the slidesToShow is greater than the number of slides, it does not create the slick-cloned slides.

Contributor guide

Research direction
Examine the slick cloned slides creation logic in the component where slidesToShow is compared to the total number of slides. Focus on the condition that determines whether cloned slides should be created.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65