akiran/react-slick

appendDots is overriding className declarations

Open

#1,533 opened on Apr 11, 2019

View on GitHub
 (9 comments) (0 reactions) (0 assignees)JavaScript (11,386 stars) (2,109 forks)batch import
good first issue

Description

with this configuration appendDots: dots => <div className="myClass"><ul>{dots}</ul></div>,

div.myClass is reasonable to expect for, div.slick-dots is resulting tough.

Contributor guide

Tech stack
react
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the source code of react slick, likely in the Dots component (e.g., src/dots.js or similar) to understand how `appendDots` merges classes. The issue suggests that the component always adds 'slick dots' class, but the user's custom className should be preserved. Look for where className is set and consider using a library like classnames to merge. Check comments in the issue for any proposed solutions or maintainer responses.