ajaxorg/ace

Add support for numeric separator in Javascript and PHP

Open

#5,256 opened on Jul 15, 2023

View on GitHub
 (5 comments) (1 reaction) (0 assignees)JavaScript (26,357 stars) (5,252 forks)batch import
effort/smallfeature-requestgood first issuemode-requestp2

Description

Describe the feature

Please add a validation for the numeric number separator in Javascript: image

Use Case

https://github.com/tc39/proposal-numeric-separator

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

ACE version used

1.23.4

Contributor guide

Tech stack
javascriptphp
Domain
frontenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScript syntaxPHP syntaxAce editor mode structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
This is a feature request to add validation for numeric separators (e.g., 1 000 000) in JavaScript and PHP within Ace. To implement, examine how numeric literals are currently tokenized in the JavaScript and PHP syntax mode files (likely under lib/ace/mode/). Using the TC39 proposal as reference, modify the regular expressions or tokenizer rules to allow underscores in numbers. Look at existing PRs or comments for guidance; one comment suggested using the 'go' mode as a reference. Coordinate with maintainers to ensure consistency with Ace's overall approach.