airbnb/rheostat

RTL Support Doesn't Work

Open

#282 opened on Aug 11, 2020

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (1,688 stars) (215 forks)batch import
bughelp wanted

Description

Thanks for your contributions and for supporting RTL!

We were testing rheostat slider and we encountered issues with RTL. (see gif below)

slider_rtl

Slider direction is flipped (opposite to the mouse movement direction)

relates to #235

Contributor guide

Tech stack
javascriptreactcss
Domain
frontendaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactCSS directionRTL concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate how the slider handles direction. Look at the component's handling of RTL and how the mouse movement maps to slider value. Review related issue #235 and the CSS direction properties. The bug may be due to incorrect calculation when dir='rtl'. Check the component's logic for updating position and consider mirroring the calculation for RTL.