airbnb/rheostat

Aria-labels can't be added to slider buttons

Open

#273 opened on Jan 3, 2020

View on GitHub
 (3 comments) (9 reactions) (0 assignees)JavaScript (1,688 stars) (215 forks)batch import
enhancementhelp wanted

Description

For compliance, I need to add aria-labels to the slider buttons in an implementation like this one: http://localhost:9001/?path=/story/slider--rtl-multiple-handle. There doesn't seem to be a way to do this currently.

Contributor guide

Tech stack
javascriptreact
Domain
frontendaccessibility
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic React knowledgeunderstanding of ARIA attributes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The issue is to add aria labels to slider buttons in the rheostat component. Start by examining the slider component source code in the repository to identify where buttons are rendered. Look for existing prop handling for accessibility attributes. Check comments on the issue for any suggested approach. Consider adding a prop like `buttonAriaLabel` that can be passed to each handle. Ensure to update the component's TypeScript definitions if present. Test the change using the existing test suite and manual verification.