airbnb/mavericks

Koin viewmodels' injection

Open

#339 opened on Jan 10, 2020

View on GitHub
 (2 comments) (11 reactions) (0 assignees)Kotlin (5,934 stars) (509 forks)batch import
help wanted

Description

I want to use Koin's extension functions for viewmodels' injections. Is there a way not to write MvRxViewModelFactory and use all the advantages of Koin? It's not very convenient to manually inject all of the dependencies into viewmodel through Factory.

Contributor guide

Tech stack
kotlinandroid
Domain
mobile
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
KotlinAndroidMavericksKoin
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate Mavericks' MvRxViewModelFactory implementation and how it creates viewmodels. Look at existing DI integration examples (e.g., Dagger). Propose an API similar to Koin's `viewModel` function that wraps Mavericks' state handling. Implement a `koinViewModel` delegate or module configuration. Reference issue #339 and any related discussions.
Koin viewmodels' injection · airbnb/mavericks#339 | Good First Issue