aio-libs/aiohttp

Add runner.serve_forever()

Open

#2746 opened on Feb 17, 2018

View on GitHub
 (15 comments) (2 reactions) (0 assignees)Python (14,286 stars) (1,997 forks)batch import
Hacktoberfestenhancementgood first issueserver

Description

Like https://docs.python.org/3.7/library/asyncio-eventloop.html#asyncio.Server.serve_forever

Contributor guide

Tech stack
python
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of asyncio event loopFamiliarity with aiohttp runner
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue requests adding a `serve forever()` method to the runner, similar to `asyncio.Server.serve forever()`. Review the aiohttp runner implementation in `aiohttp/web runner.py` and the asyncio documentation linked. Check existing comments for discussion on design. Implement the method by wrapping the underlying server's `serve forever` while handling cleanup and signal handling.