refactor(aidd-orchestrator): the check zone says when to stop, and reviews its axes in one round
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Domain
- documentation
Research direction
Read plugins/aidd-orchestrator/skills/01-sdlc/references/03-check.md alongside the issue's acceptance criteria, focusing on the loop exit rule and review-axis dispatch. Done means the file states the reachable-input exit condition, gives out-of-scope findings a destination, combines parallel findings, and preserves regression re-entry after a fix.
Written by the indexing model from the issue text.
Description
Problem
The Check zone says to re-enter after every new candidate and never says when to leave. It also reviews with one checker, sequentially, while its own behavior section says to parallelize independent work.
Measured on a real run (#250, PR #885): six review rounds, ten subagents, all sequential.
| Round | Score | What it found |
|---|---|---|
| 1 | 0.65 | the address pattern missed the bare form a contributor types; 8 addresses already in the tree were invisible |
| 2 | 0.68 | adding an action to a skill was refused in both orders, including the one 04-skill-generate documents |
| 3 | 0.78 | ordinary prose satisfied the router rule; 20 of 78 row deletions undetected |
| 4 | 0.80 | three regressions the previous round had introduced |
| 5 | 0.82 | shapes no input in the tree reaches |
| 6 | 0.86 | shapes no input in the tree reaches |
Rounds 1 to 4 each found a defect a real edit would hit. Rounds 5 and 6 found only shapes nothing in the repository can produce, and cost roughly an hour between the reviews themselves and the fixes they prompted.
Total: 2h12 of agent wall-clock and ~1.4M subagent tokens, for work where the axes were independent the whole time.
Scope
A stated exit condition. Check leaves the loop when the reviewer returns no finding that an input reachable from the repository can trigger. A finding about a shape nothing produces is recorded — as a spec limit or a follow-up issue — and does not re-enter the loop. The zone says this, so it is a rule and not a judgement call made differently each run.
Review axes run in parallel. Code, contract conformance and adversarial inputs are independent: none needs another's verdict. One reviewer per axis, dispatched together, their findings merged before the loop decides. A regression pass after a fix stays single, because it only re-checks what changed.
Acceptance criteria
-
plugins/aidd-orchestrator/skills/01-sdlc/references/03-check.mdstates when the loop ends, in terms a reader can apply without knowing this run. - A finding the exit condition excludes has a stated destination, so nothing is dropped by being out of scope.
- The zone dispatches its review axes in one round rather than one after another, and says how their findings combine.
- A run that finds a defect in round one still re-enters Check after the fix — the exit condition narrows the loop, it does not remove it.
Out of scope
- Model tiering per step. That is #677.
- Measuring what a run costs.
aidd-telemetryalready does it and is simply not enabled on this repository.
- Dominant language
- TypeScript
- Stars
- 481
- Forks
- 45
- Avg merge
- 19h 38m
- Merged PRs (30d)
- 108
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ai-driven-dev/framework
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
ai-driven-dev/framework#873 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
ai-driven-dev/framework#872 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
ai-driven-dev/framework#625 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
ai-driven-dev/framework#467 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
ai-driven-dev/framework#916 ·
All issues in ai-driven-dev/framework
Similar issues
-
VerificationGate: ATTRIBUTION quote guard never matches a normal quotation (\b around the quote) Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
danielmiessler/LifeOS#2234 ·
-
T: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
Mend: dependency security vulnerability untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 70/100