workflow: enforce the collaborator gate (author_association)
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
Research direction
Start with the github-as-substrate workflow and its existing if: expression. Add the collaborator gate while handling issue and comment author_association values, then verify with a non-collaborator account or fork PR that a spin block is blocked and an allowed association still runs.
Written by the indexing model from the issue text.
Description
the github-as-substrate workflow's if: only checks for the ```spin marker:
if: >
contains(github.event.issue.body, '```spin') ||
contains(github.event.comment.body, '```spin')
the header comment claims a collaborator gate, but there is none — any
stranger can open an issue with a ```spin block and spend the repo's Actions
minutes (a free-compute faucet). discovered while proving #5 live.
fix
add an author_association check to the if:, e.g.
if: >
(contains(github.event.issue.body, '```spin') ||
contains(github.event.comment.body, '```spin')) &&
contains(fromJSON('["OWNER","MEMBER","COLLABORATOR"]'),
github.event.issue.author_association ||
github.event.comment.author_association)
verify with a non-collaborator account (or a fork PR) that it actually
blocks. note author_association is per-event (issue vs comment) — handle both.
- Dominant language
- Ruby
- Stars
- 1
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ahoward/spin
-
transport
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
-
routing
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
deploy
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
deploy spinel
Difficulty 5/5 Over a week Newbie friendliness 38/100
Similar issues
-
user-reported
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Kong/developer.konghq.com#7316 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
TheOdinProject/curriculum#31408 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
notch8/utk_knapsack#148 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Homebrew/homebrew-cask#288729 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100