agrafix/Spock

Multiple file upload, but only one file in request body

Open

#143 opened on May 9, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Haskell (596 stars) (54 forks)batch import
bughelp wanted

Description

Multiple file upload seems to not be handled correctly. If a user selects multiple files to upload on a file input field, such as the following, then the request body will contain only one file associated with the input field.

<input multiple name="files" id="files" type="file">

From a quick look at the code, maybe this part should use HM.fromListWith (<>) and a HashMap Text [UploadedFile]?

Contributor guide

Tech stack
None
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
HaskellSpock framework
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue is in the Spock web framework. The bug is in the file upload handling in Spock core/src/Web/Spock/Internal/Wire.hs at line 398. The suggested fix is to change the HashMap construction to use `HM.fromListWith (<>)` to collect multiple files under the same key. The code currently likely only retains one file per input field. If you are new to Haskell and Spock, first understand the `Wire.hs` module and how uploads are parsed. Then implement the change and test with multiple file selection.