agrafix/Spock

Multiple file upload, but only one file in request body

Open

#143 opened on May 9, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Haskell (54 forks)batch import
bughelp wanted

Repository metrics

Stars
 (596 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Multiple file upload seems to not be handled correctly. If a user selects multiple files to upload on a file input field, such as the following, then the request body will contain only one file associated with the input field.

<input multiple name="files" id="files" type="file">

From a quick look at the code, maybe this part should use HM.fromListWith (<>) and a HashMap Text [UploadedFile]?

Contributor guide

Research direction
Inspect the file at the linked location and consider using `HM.fromListWith (<>)` with a `HashMap Text [UploadedFile]` to accumulate multiple files per input name.
Tech stack
haskell
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
HaskellGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75