agraboso/redux-api-middleware

Feature Request: abort request with AbortController signal

Open

#187 opened on May 30, 2018

View on GitHub
 (9 comments) (7 reactions) (0 assignees)JavaScript (1,487 stars) (202 forks)batch import
enhancementhelp wanted

Description

Most probably not a small set of developers had run into wanting to abort an ongoing fetch call. For instance an autocomplete input that makes requests as key events are happening, even with a debouncer.

Now in most browsers AbortController API is available in order to fulfill this task.

This issue is an open question for the community if there's interest in including this feature and what we could achieve. I think an extension of RSAA is needed at least.

What do you guys think? I could definitely set up some code proposals or tests in the next days if this idea gains traction 😃

Contributor guide

Tech stack
javascript
Domain
frontendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Redux middlewareRSAA formatAbortController API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Start by examining the existing RSAA structure in the source code (likely in src/ directory). Look at how requests are made currently (probably using fetch). Understand the middleware chain and how actions are processed. Then propose a way to integrate AbortSignal into the RSAA, possibly by adding a signal property to the action. Check if there are any existing discussions in the comments of this issue (issue #187) for ideas. Additionally, review the library's test suite to see how to add tests for the abort functionality.