adopted-ember-addons/ember-light-table

Make `minResizeWidth` take a string like `width` or vice-versa

Open

#534 opened on Jan 9, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (130 forks)github user discovery
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (312 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently the Column class requires minResizeWidth to be a number (in px) while width is provided as a string like so width: '100px'. I think it would be good to have these two properties work the same for consistency sake. For backward compatibility, we could allow a number or a string for both.

Contributor guide

Research direction
Modify the `minResizeWidth` property to accept both number and string values, similar to `width`. Ensure backward compatibility by handling coercion.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75