adopted-ember-addons/ember-light-table

table height attribute warning is annoying

Open

#502 opened on Oct 29, 2017

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (130 forks)github user discovery
foreign-addonhelp wanted

Repository metrics

Stars
 (312 stars)
PR merge metrics
 (PR metrics pending)

Description

#449 made it optional to specify a table height attribute, which is great for those of us sizing the table with CSS. However, when I'm doing this intentionally, I don't want to see these warnings.

Can we add an option or setting that will silence these, probably on a per-table basis? That way I could provide an attribute like requireHeight: false to each table where I'm explicitly choosing not to set the height because I know CSS has it taken care of.

I think this should be pretty simple so I'm happy to put together a PR if that sounds appropriate :v:

Contributor guide

Research direction
Add a new property like `requireHeight` to the table component that, when set to false, suppresses the height warning.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitEmber.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70