adopted-ember-addons/ember-light-table

Adding CSS classes to thead, tfoot and tbody

Open

#492 opened on Oct 11, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (130 forks)github user discovery
enhancementhelp wantedideas-wanted

Repository metrics

Stars
 (312 stars)
PR merge metrics
 (PR metrics pending)

Description

@fran-worley https://github.com/offirgolan/ember-light-table/issues/99#event-734291228:

Sorry to bump an old issue but I believe this only partially resolves issues marrying up Bootstraps css styles with ember-light-table.

We need to be able to apply styles directly to the 'thead' too ('.thead-default' is just one style example from BS v4). Could the api be harmonized to allow you to add classes directly to table elements (table, thead, tbody etc.).

As a user, I would expect that setting class on {{t.head}}, {{t.body}} and {{t.foot}} set these classes on the rendered <thead>, <tbody> and <tfoot> elements.

I'm not sure, if we can use class as the attribute name here, since it's a magic Component keyword that automatically sets the class HTML attribute for the rendered component element.

Contributor guide

Research direction
Examine how ember light table's t.head, t.body, and t.foot components are implemented, and modify them to pass the class attribute to the underlying HTML elements (thead, tbody, tfoot). Consider using the component's class attribute or a separate property like 'tableClass'.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Ember.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60