adopted-ember-addons/ember-light-table

Show helpful warning when trying to mutate an AdapterPopulatedRecordArray

Open

#470 opened on Jul 28, 2017

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)JavaScript (130 forks)github user discovery
cookbookenhancementhelp wantedideas-wanted

Repository metrics

Stars
 (312 stars)
PR merge metrics
 (PR metrics pending)

Description

People are constantly running into #423: The result of a server query is immutable

We should improve the examples, I think.

And we can add assertions to all row mutation methods to display more helpful errors when trying to mutate an AdapterPopulatedRecordArray.

Contributor guide

Research direction
Identify the row mutation methods in AdapterPopulatedRecordArray and add assertions that display helpful warnings when mutation is attempted. Also improve the examples as mentioned.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70