adopted-ember-addons/ember-light-table

Fastboot support and SEO mode

Open

#468 opened on Jul 21, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (130 forks)github user discovery
help wantedideas-wantednew-feature

Repository metrics

Stars
 (312 stars)
PR merge metrics
 (PR metrics pending)

Description

I haven't used ember-light-table in Fastboot yet. I would expect that it should run without problems, since users haven't voiced complaints yet. Did someone already try it?

I think a Fastboot enabled SEO mode is an interesting idea. The markup generated by ELT is a bit strange. The table is fragmented into two / three separate <table> tags. I can imagine that this doesn't make much sense to search engines / crawlers.

If we're running in Fastboot, we could generate a more standards compliant markup.

Fastboot currently has no notion of "rehydration", but rather rerenders the whole component and replaces the server-side generated tags. For the most part, I don't expect this to cause any problems / layout flashes. However, fixed headers / footers could cause weird behavior, because of vertically overflowing table content (rows).

Contributor guide

Research direction
Investigate current Fastboot compatibility of ember light table and propose a standards compliant SEO mode for server side rendering.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
EmberFastboot
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50