adopted-ember-addons/ember-light-table

Accept an array as `valuePath`

Open

#456 opened on Jul 13, 2017

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (130 forks)github user discovery
enhancementhelp wantedmaybe-breakingpossible-addon

Repository metrics

Stars
 (312 stars)
PR merge metrics
 (PR metrics pending)

Description

I often find myself needing to compute a cell's value dependent of more than one field of the row. But the current API allows only passing one key as the valuePath.

I work around this by just accessing whatever properties I need from the row attribute that is passed to the cellComponent. I think that's pretty ugly.

If we would allow users to pass a string or an array of strings to valuePath, then (in the latter case) we could pass an array of values as value to the cellComponent.

Contributor guide

Research direction
Locate the relevant cell component where valuePath is used. Modify the logic to accept either a string or an array of strings, and when an array is passed, resolve each key and pass the array of values to the cellComponent. Ensure backwards compatibility.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
EmberJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75