adopted-ember-addons/ember-light-table

classNames, cellClassNames cannot be arrays

Open

#416 opened on Jun 1, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (130 forks)github user discovery
buggood first issuehelp wanted

Repository metrics

Stars
 (312 stars)
PR merge metrics
 (PR metrics pending)

Description

https://github.com/offirgolan/ember-light-table/blob/v1.8.6/addon/classes/Column.js#L259-L265

  /**
   * Class names to be applied to all cells of this column
   *
   * @property cellClassNames
   * @type {String | Array}
   */
  cellClassNames: null,

https://github.com/offirgolan/ember-light-table/blob/v1.8.6/addon/components/cells/base.js#L15-L25

/**
 * @module Cell Types
 * @class Base Cell
 */

const Cell = Component.extend({
  layout,
  tagName: 'td',
  classNames: ['lt-cell'],
  attributeBindings: ['style'],
  classNameBindings: ['align', 'isSorted', 'column.cellClassNames'],
  // ..
});

The same goes for classNames.

When passed an array of class names, the array is stringified (concatenated with ,).

I'll submit a PR when I can get around to it. Merely putting this here for tracking. :slightly_smiling_face:
Otherwise this would be a great PR for a first-time contributor! :smile:

Contributor guide

Research direction
Inspect the Column.js and base.js files to understand how classNameBindings processes arrays. Modify the cell component to handle arrays by converting them to space separated strings or use a computed property.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
javascript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80