adopted-ember-addons/ember-light-table

Number.isNaN and Number.parseInt breaks app in IE

Open

#343 opened on Feb 20, 2017

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (130 forks)github user discovery
good first issuehelp wanted

Repository metrics

Stars
 (312 stars)
PR merge metrics
 (PR metrics pending)

Description

Hi,

I don't think you should use Number.isNaN and Number.parseInt in the lt-body component: https://github.com/offirgolan/ember-light-table/blob/master/addon/components/lt-body.js as it breaks apps in IE. I've tested IE 11. I think you should use a polyfill or isNaN, and parseInt directly.

Thanks, Camille

Contributor guide

Research direction
Replace Number.isNaN with isNaN and Number.parseInt with parseInt in the lt body component, or add a polyfill for IE compatibility.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80