adopted-ember-addons/ember-changeset-validations

Date validator request

Open

#204 opened on Nov 19, 2019

View on GitHub
 (18 comments) (0 reactions) (0 assignees)JavaScript (98 forks)github user discovery
good first issue

Repository metrics

Stars
 (216 stars)
PR merge metrics
 (PR metrics pending)

Description

This package is currently not providing a Date validator, which would be very useful for validating date-type inputs. Such a validator is already provided by ember-validators but is not in this project.

https://github.com/offirgolan/ember-validators/blob/v2.0.0/addon/date.js

Having it available would allow us to use changesets for date inputs with something better than

validateFormat({ regex: /[0-9][0-9][0-9][0-9]-[0-9][0-9]-[0-9][0-9]/ })

which is currently the best, but somewhat hacky, implementation option.

Contributor guide

Research direction
Examine existing validators (e.g., validateFormat, validateLength) in the project to understand the pattern. Then implement a date validator that accepts a date format or uses standard date validation. Reference the implementation in ember validators (https://github.com/offirgolan/ember validators/blob/v2.0.0/addon/date.js).
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75