adobe/react-spectrum

Select does not propagate change event

Open

#6,217 opened on Apr 17, 2024

View on GitHub
 (7 comments) (7 reactions) (0 assignees)TypeScript (1,500 forks)auto 404
buggood first issue

Repository metrics

Stars
 (15,634 stars)
PR merge metrics
 (PR metrics pending)

Description

Provide a general summary of the issue here

When you change a value in a Select element there is no change event that bubbles causing patterns like <form onChange> to stop working.

🤔 Expected Behavior?

The select should trigger a change event like normal form elements.

😯 Current Behavior

The <Select> element does not behave like a native <select> element by not bubbling change events.

💁 Possible Solution

I believe the reason why this currently does not work is because the select just get's re-rendered. Maybe adding a manual change event in the <HiddenSelect> would solve this.

🔦 Context

No response

🖥️ Steps to Reproduce

https://codesandbox.io/p/sandbox/twilight-voice-tjmwcl?file=%2Fsrc%2FApp.js%3A4%2C9

Version

1.0.0-rc.0

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

If other, please specify.

No response

What operating system are you using?

macOS

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

Contributor guide

Research direction
Inspect the HiddenSelect component and its event handling. Ensure a native change event is dispatched when the select value changes. Look for existing tests and add one that verifies the event propagation.
Tech stack
javascripttypescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitReactTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65