adobe/react-spectrum

useToolbar: If a button is partially visible, it doesn't scroll into view

Open

#5,885 opened on Feb 15, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (1,500 forks)auto 404
bughelp wanted

Repository metrics

Stars
 (15,634 stars)
PR merge metrics
 (PR metrics pending)

Description

Provide a general summary of the issue here

If a button is partially visible and it's the last button in toolbar, it doesn't scroll into view when focused using keyboard.

🤔 Expected Behavior?

Any trigger item should come fully into view when focused

😯 Current Behavior

Focused button doesn't come fully into view

🖥️ Steps to Reproduce

https://codesandbox.io/p/sandbox/vigorous-glade-zctnr5?file=%2Fsrc%2FApp.js%3A19%2C9

The last button never comes in view fully when focus is moved using keyboard.

Version

3.30.0

What browsers are you seeing the problem on?

Chrome

What operating system are you using?

MacOS

Contributor guide

Research direction
Investigate the scrollIntoView logic in the useToolbar hook. Focus on the case where a button is partially visible; ensure that the element scrolls fully into view on focus. Use the provided CodeSandbox to reproduce the issue and trace the handler path.
Tech stack
reacttypescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactReact Ariakeyboard navigation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70