adobe/react-spectrum

Investigate onCellAction behavior with selectionMode="replace"

Open

#3,236 opened on Jun 15, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (1,500 forks)auto 404
help wanted

Repository metrics

Stars
 (15,634 stars)
PR merge metrics
 (PR metrics pending)

Description

onCellActions behave oddly with selectionMode="replace" (aka highlight selection mode), preventing row selection on click. This is specifically for tables created with the aria hooks, the React Spectrum TableView doesn't support cell actions.

Ideally, onCellAction should behave similarly to onRowAction in selectionMode="replace" (i.e. described here in https://react-spectrum.adobe.com/react-aria/useTable.html#row-actions). May require changes to usePress to continue propagation, try stuff out.

Contributor guide

Research direction
Investigate the usePress hook to understand how click events propagate in selectionMode='replace'. Check how onRowAction and onCellAction are handled, and consider modifications to usePress to allow continued propagation when onCellAction is triggered.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
ReactTypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50