adobe/react-spectrum

onCancel should fire in AlertDialog if Escape is pressed

Open

#1,773 opened on Apr 7, 2021

View on GitHub
 (7 comments) (0 reactions) (0 assignees)TypeScript (1,500 forks)auto 404
good first issue

Repository metrics

Stars
 (15,634 stars)
PR merge metrics
 (PR metrics pending)

Description

🐛 Bug Report (or maybe feature request?)

When adding an onCancel handler to an AlertDialog, it should fire if the dialog is closed via the Escape key.

See here for a repro: https://codesandbox.io/s/adoring-meadow-7cl4c?file=/src/App.js

Open the dialog, click Cancel, dialog will close, you'll see 'Canceled' in the console. Open the dialog, press Escape key, dialog will close, no 'Canceled' in the console.

Contributor guide

Research direction
Inspect the AlertDialog component to see how the Escape key is handled. Check if there is an event listener for keydown and if it triggers the onCancel callback. Look for any missing propagation or conditional logic that prevents onCancel from firing when Escape is pressed.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70