[bug] removeDefaultStyles does not remove default styles on ResponsiveGrid
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- react, typescript
- Domain
- frontend
Research direction
Start in src/components/ResponsiveGrid.tsx around line 45 and trace how removeDefaultStyles, isInEditor, and gridClassNames determine the className. Reproduce the issue with ResponsiveGrid, then verify that the expected grid styles are removed when removeDefaultStyles is enabled while editor behavior remains correct.
Written by the indexing model from the issue text.
Description
Describe the bug
Adding removeDefaultStyles to ResponsiveGrid does not remove styles.
if (isInEditor || !props.removeDefaultStyles) {
className = `${className} ${props.gridClassNames || ''} ${ClassNames.CONTAINER}`;
}
The code here shows that isInEditor will always return true and it seems impossible to override gridClassNames prop.
We want to use a custom grid but this is forcing our hand.
Package version
2.1.1
To Reproduce
- Add removeDefaultStyles to ResponsiveGrid
Expected behavior
Grid styles removed in AEM
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
- Dominant language
- TypeScript
- Stars
- 68
- Forks
- 35
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from adobe/aem-react-editable-components
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
adobe/aem-react-editable-components#288 · 1 comment ·
-
feature-request
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
feature-request
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 25/100
adobe/aem-react-editable-components#235 · 1 comment ·
All issues in adobe/aem-react-editable-components
Similar issues
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 91/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100