adhit-r/fairmind

Align plot_numeric_distributions module path with tests

Open

#146 opened on Jan 6, 2026

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (12 forks)auto 404
buggood first issuetesting

Repository metrics

Stars
 (9 stars)
PR merge metrics
 (PR metrics pending)

Description

Summary

The new plot_numeric_distributions helper added in PR #145 lives under apps/ml/visualizations/data_distribution.py, but the associated tests in tests/test_distribution.py currently import from a backend utilities path. This causes pytest to fail with ModuleNotFoundError once tests are run against main.

Tasks

  • Decide the canonical location for the data distribution utility:
    • Either keep it under apps/ml/visualizations/data_distribution.py, or
    • Move it under a backend utilities namespace (e.g. apps/backend/utils/visualization/data_distribution.py).
  • Update tests/test_distribution.py to import plot_numeric_distributions from the chosen canonical module path.
  • Run pytest tests/test_distribution.py and ensure the tests pass.

Acceptance Criteria

  • pytest tests/test_distribution.py runs successfully without import errors.
  • The visualization module and tests both reference the same, well-defined import path.
  • No breaking changes to the public API of plot_numeric_distributions.

Contributor guide

Research direction
Decide whether to keep the module under `apps/ml/visualizations/data distribution.py` or move it to `apps/backend/utils/visualization/data distribution.py`, then update the import in `tests/test distribution.py` to match and run tests.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85