addyosmani/timing.js

ie8 doesn't safely fail

Open

#6 opened on Sep 25, 2014

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (1,504 stars) (123 forks)batch import
enhancementhelp wanted

Description

Want to encorporate this in our product behind a flag, however if the browser is ie8 (argh), ideally it just needs to fail silently without throwing a script error. Can we prevent the error for ie8?

Script throws an error

"'timing is null or not an object"

Contributor guide

Tech stack
javascript
Domain
frontendperformance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptUnderstanding of browser detectionFamiliarity with Navigation Timing API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the code in timing.js, likely the main script, to identify where performance.timing is accessed. Add a check for the existence of performance and performance.timing before using it, or wrap in a try catch to prevent the error in IE8. Ensure that in unsupported browsers, the library fails silently without throwing exceptions.