addyosmani/timing.js

ie8 doesn't safely fail

Open

#6 opened on Sep 25, 2014

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (123 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (1,504 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Want to encorporate this in our product behind a flag, however if the browser is ie8 (argh), ideally it just needs to fail silently without throwing a script error. Can we prevent the error for ie8?

Script throws an error

"'timing is null or not an object"

Contributor guide

Research direction
Add a conditional check for IE8 to prevent accessing the Navigation Timing API, returning early or providing a fallback.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80