addyosmani/critical

Remove query string from stylesheet path

Open

#551 opened on Jan 31, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (9,902 stars) (457 forks)batch import
bughelp wanted

Description

In my simple PHP file I reference my stylesheet as follows:

<link rel="stylesheet" href="css/style.css?v=<?php echo filemtime( 'css/style.css' ); ?>"

When using the CLI, I get the following error:

Error: File not found: css/style.css?v=<?php echo filemtime( 'css/style.css' ); ?>

This could be addressed by automatically removing query strings like ?v before trying to access the file. After that it works as expected.

Contributor guide

Tech stack
javascript
Domain
frontendperformance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptunderstanding of file paths
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Investigate how the tool resolves file paths in the CLI. The issue suggests removing query strings (e.g., `?v=...`) from the href before accessing the file. Check the source code for where `css/style.css?v=...` is passed; likely in `lib/` or `src/`. Look for `path` or `fs` operations. The fix would involve stripping the query string using `url.parse` or string split. No linked PRs or comments.
Remove query string from stylesheet path · addyosmani/critical#551 | Good First Issue