addyosmani/critical

Remove query string from stylesheet path

Open

#551 opened on Jan 31, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (457 forks)batch import
bughelp wanted

Repository metrics

Stars
 (9,902 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In my simple PHP file I reference my stylesheet as follows:

<link rel="stylesheet" href="css/style.css?v=<?php echo filemtime( 'css/style.css' ); ?>"

When using the CLI, I get the following error:

Error: File not found: css/style.css?v=<?php echo filemtime( 'css/style.css' ); ?>

This could be addressed by automatically removing query strings like ?v before trying to access the file. After that it works as expected.

Contributor guide

Research direction
Locate the file reading function in the critical package, remove the query string from the path before passing it to the file system.
Tech stack
javascript
Domain
devtools
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85