actualbudget/actual

[Bug]: Filtered balance on Split's notes not calculating properly

Open

#4381 opened on Feb 14, 2025

View on GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (7,129 stars) (603 forks)batch import
bughelp wantedtransactions

Description

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

When trying to filter transactions by Note, the "Filtered Balance" doesn't include the split if each line doesn't also have the note.

I would expect that the split be included if each split note is empty. If each split has a different note, then those splits should be filtered accordingly. For example, in the image, if the note on the External Purchases split said "Family" I would not expect it to calculate in the "contains kro" filter. However, those splits that are empty should calculate. Otherwise, every split needs to have all fields filed out to calculate properly.

Image

How can we reproduce the issue?

How can we reproduce the issue? Create a split transaction, notate the main split, but not the individual sub-splits, filter by note. Filtered Balance will be different than expected, and not show non-notated sub-splits.

Where are you hosting Actual?

Locally via Yarn

What browsers are you seeing the problem on?

Chrome, Firefox

Operating System

Windows 11

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of split transactions in ActualFamiliarity with note filtering logic
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the filtering logic for split transactions in the Actual codebase. Focus on how the 'Filtered Balance' is computed when a note filter is applied. Check the transaction list component and the account calculation functions. The bug suggests that sub splits without notes are not being considered when the parent transaction's note matches the filter. Expected behavior is that empty notes should be inherited from the parent. Look at files related to transaction filtering and balance calculation, such as in the loot core or desktop client packages. Review any existing tests for split transaction filtering.