actualbudget/actual

[Tech Enhancement] Implement standard sizes on `Text` and `Input` components

Open

#3771 opened on Nov 3, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (7,129 stars) (603 forks)batch import
help wanteduser interface

Description

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

Currently, there is no standard sizes for texts and inputs across the app. This enhancement is to extend the Text and Input components to have a size prop which accepts some standard size values:

  • small
  • medium
  • large
  • extra-large

These standard sizes should vary between screen sizes e.g. different set of width and height for desktop, tablet, mobile

This change should help make all the texts and inputs more uniform in sizes throughout the app

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Knowledge of React componentsUnderstanding of responsive design
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the existing Text and Input component implementations in the actualbudget/actual repository, likely located in packages/desktop client/src/components/. Create a size prop that accepts 'small', 'medium', 'large', 'extra large'. Define CSS classes or styled components that vary width/height based on screen size using media queries. Ensure the changes are consistent across all instances of Text and Input. No linked PRs or comments yet; seek maintainer feedback on the desired responsive breakpoints.