actualbudget/actual

[Bug]: Date selector in schedules for Mac desktop app doesn't handle dates in a 6th row correctly

Open

#3701 opened on Oct 21, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (7,129 stars) (603 forks)batch import
bugelectrongood first issuehelp wanteduser interface

Description

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

This might be a bit niche, but it's reproducible on my system. On the MacOS desktop app (ie, not in a browser) it is not possible to select any date that causes the date selector to overflow in to a 6th row of days when configuring a schedule.

Examples as below are September and December 2024 where the month starts at the end of the week causing there to be 6 rows of days rather than 5. When any day in the 6th row is clicked the date selector closes with no date selected as if the click had been completely outside the date selector. image image

For contrast, a 5 row month works as expected. image

This does not happen in Chrome or Safari on MacOS. Can't test on mobile as schedules are not available there. Date selectors in other areas of the application (eg. transaction entry) seem to work fine. Typing the date in to the text box part of the date selector also works fine.

Restarting the application/resizing the window does not change the bad behaviour.

Where are you hosting Actual?

Pikapods

What browsers are you seeing the problem on?

Desktop App (Electron)

Operating System

Mac OSX

Contributor guide

Tech stack
javascriptreactelectron
Domain
frontenddesktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactElectronJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the date picker component used for schedules in the Mac desktop app. Look at the date selection logic, specifically how the calendar grid handles months with 6 rows. Compare behavior in Electron vs browser. The issue may be due to event handling differences or CSS overflow. Check the date picker's click handler and ensure it correctly captures clicks on days in the 6th row. Also review any Electron specific configurations.