[bug] v2.0 used with compression level 0

Open Beginner friendly
#814 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
67/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
github-actions, typescript
Domain
ci-cd, devops

Research direction

Start by locating the upload-artifact code that handles compression-level and selects the ZIP version. Reproduce the issue by uploading a directory with compression-level: 0, then verify that the output matches zip by using v1.0 rather than v2.0.

Written by the indexing model from the issue text.

Description

bug
What happened?

It's common practice to use v1.0 when only storing files (compression level 0) and this is the behavior of zip, but this action always uses v2.0

What did you expect to happen?

Output to match what would happen with zip

How can we reproduce it?

Upload a directory with compression-level: 0

Anything else we need to know?

Would be a behavior change, but shouldn't break anything since most tools that support v2.0 will support v1.0

What version of the action are you using?

v7.0.1

What are your runner environments?

linux

Are you on GitHub Enterprise Server? If so, what version?

No response

Dominant language
TypeScript
Stars
4.2k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from actions/upload-artifact

All issues in actions/upload-artifact

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.