acdlite/redux-router

Router state duplication

Open

#59 opened on Sep 18, 2015

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (2,316 stars) (215 forks)batch import
help wanted

Description

It seems to me that there is some overhead with keeping router state. When using redux-react-router we have router state in our app state and also in the component's props. So we have

this.props.router.location this.props.router.component this.props.router.params this.props.router.routes

this.props.params this.props.location this.props.history this.props.routes this.props.route this.props.routeParams

Is there any way to reduce number of props kept?

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactReduxReact Router
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the source code of redux router to understand how router state is passed as props to components. Look at the redux react router binding to see if there is a way to reduce duplication by using React Router's higher order components or Redux selectors. Review the comments in issue #59 for any proposed solutions.