acdlite/react-remarkable

Remove dangerouslySetInnerHTML

Open

#8 opened on Oct 14, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (57 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (455 stars)
PR merge metrics
 (PR metrics pending)

Description

Was quite enthused to see this but turned out to be a wrapper. Is there any possibility of adding true React support via AST, along the lines of https://github.com/rexxars/react-markdown ?

That is the "correct" approach. React does DOM diffs, so with ASTs it will only render the changed parts instead of re-rendering everything like right now this repo does, which brings perf and other improvements.

Contributor guide

Research direction
Study the react markdown library to understand how it uses AST for rendering and apply similar approach to react remarkable by integrating with remarkable's parser.
Tech stack
javascriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
ReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50