[Bug][CMAKE][WINDOWS]: missing hardening in CMake/AbseilDll.cmake
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 65/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- cmake, cpp
- Domain
- build-system
Research direction
The issue points to CMake/AbseilDll.cmake lines 564-566 and absl/base/CMakeLists.txt. First, examine the hardening target in base/CMakeLists.txt and compare its inclusion to other targets in ABSL_INTERNAL_DLL_TARGETS. Add 'hardening' to the list in AbseilDll.cmake, then test a Windows CMake build to verify the target is linked correctly.
Written by the indexing model from the issue text.
Description
Describe the issue
in https://github.com/abseil/abseil-cpp/commit/d85c5281b875fd58d86524a0b781c09e3248b216
absl::hardening has been added to absl/base/CMakeLists.txt.
But it seems the AbslDLL.cmake miss some bit aka hardening cmake target has not been added to ABSL_INTERNAL_DLL_TARGETS in CMake/AbseilDll.cmake...
see:
https://github.com/abseil/abseil-cpp/blob/fe690e639469d2a3c86bc74dd2456371288d1f28/CMake/AbseilDll.cmake#L564-L566
Steps to reproduce the problem
windows cmake build ?
What version of Abseil are you using?
20260817.0
What operating system and version are you using?
windows msvc...
What compiler and version are you using?
cl.exe
What build system are you using?
cmake
Additional context
No response
- Dominant language
- C++
- Stars
- 18.1k
- Forks
- 3.2k
- Avg merge
- 12h 35m
- Merged PRs (30d)
- 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from abseil/abseil-cpp
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
abseil/abseil-cpp#2168 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
abseil/abseil-cpp#2167 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
abseil/abseil-cpp#2153 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
abseil/abseil-cpp#2027 · 2 reactions ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
abseil/abseil-cpp#1875 · 2 reactions ·
All issues in abseil/abseil-cpp
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
bug-unconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
NVIDIA/cuda-samples#453 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
infiniflow/infinity#3502 ·