abetlen/llama-cpp-python

suppress_stdout_stderr failing in notebooks

Closed

#872 opened on Nov 5, 2023

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)Python (1,441 forks)batch import
bughelp wanted

Repository metrics

Stars
 (10,557 stars)
PR merge metrics
 (Avg merge 1d 5h) (68 merged PRs in 30d)

Description

Expected Behavior

Loading a model with verbose=False should not print things.

Current Behavior

verbose=False has no effect in notebooks (I tested with VS Code notebooks, but I think it is ipykernel related)

Steps to Reproduce

Just load a model with verbose=False and observe output in a notebook environment.

How to fix

The patch given in the ipykernel issue below fixes the issue for me (but requires me to do my own override of stdout and stderr since the patch also causes suppress_stdout_stderr to crash as currently written). A real fix might involve integrating this into suppress_stdout_stderr directly.

https://github.com/ipython/ipykernel/issues/795

thanks!

Contributor guide

Research direction
The issue is about `suppress stdout stderr` not working in notebook environments. The fix likely involves modifying the `suppress stdout stderr` function in the codebase, referencing the ipykernel issue (https://github.com/ipython/ipykernel/issues/795) for a patch. The function may live in a utility module; check the repository's source tree for relevant files. Integrate the patch to handle stdout/stderr redirection properly for ipykernel.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
understanding of Python's io modulebasic knowledge of ipykernel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60