ROCM Build Target or Build Instructions are incorrect
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 75/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- cmake, python
- Domain
- build-system, documentation
Research direction
Check the README file for the ROCM build instructions. Look at the CMakeLists.txt or build scripts to see if the target is named GGML_HIPBLAS or GGML_HIP. Update the README with the correct CMake argument, then verify by running the build command locally.
Written by the indexing model from the issue text.
Description
It seems that at some point the build target for ROCM was renamed from HIPBLAS to HIP. I'm not sure if this was inadvertent or deliberate, but either way, the build instructions for ROCM are incorrect. The README says to use:
CMAKE_ARGS="-DGGML_HIPBLAS=on" pip install llama-cpp-python
However, to successfully build ROCM, the command is actually:
CMAKE_ARGS="-DGGML_HIP=on" pip install llama-cpp-python
This is obviously a fairly trivial fix, but I haven't created a PR as I'm not sure if it's the docs or the build target name that is incorrect.
- Dominant language
- Python
- Stars
- 10.6k
- Forks
- 1.5k
- Avg merge
- 6h 43m
- Merged PRs (30d)
- 2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from abetlen/llama-cpp-python
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
abetlen/llama-cpp-python#2371 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
abetlen/llama-cpp-python#2352 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
abetlen/llama-cpp-python#2211 · 2 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
abetlen/llama-cpp-python#2210 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
abetlen/llama-cpp-python#2145 ·
All issues in abetlen/llama-cpp-python
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
learningequality/ricecooker#747 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
BSData/horus-heresy-3rd-edition#3171 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
run-llama/llama_index#23199 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
KhronosGroup/glTF-Blender-IO#2769 ·