JSDoc examples show wrong field names (supplier/borrower instead of sender)

Open Beginner friendly
#149 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
76/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Quiet
Tech stack
typescript
Domain
documentation

Research direction

Inspect the JSDoc examples for supply(), withdraw(), borrow(), and repay(), then compare their parameter fields with the actual TypeScript types. Update the examples to use sender instead of supplier or borrower, and verify that each example matches the types used by @aave/client 0.9.2.

Written by the indexing model from the issue text.

Description

The JSDoc examples for supply(), withdraw(), borrow(), and repay() show using supplier or borrower fields, but the actual TypeScript types require sender. Took me a bit to figure out why my code wasn't working.

Example from JSDoc:
supply({ supplier: evmAddress('0x...'), ... })

What actually works:
supply({ sender: evmAddress('0x...'), ... })

Using @aave/client 0.9.2

Dominant language
TypeScript
Stars
31
Forks
22
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aave/aave-sdk

All issues in aave/aave-sdk

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.