aalhour/C-Sharp-Algorithms

IsAnagram logic needs to be fixed

Open

#11 opened on Aug 20, 2015

View on GitHub
 (1 comment) (0 reactions) (1 assignee)C# (1,409 forks)batch import
buggood first issue

Repository metrics

Stars
 (5,736 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I think the IsAnagram() method doesn't work as expected. For example, it would fail for the below string combinations ("abc","bbb") or ("acdf", "bcde").

I think a simple LINQ implementation would be easy enough to implement here. If you like, I could do that and also implement unit tests for it.

Contributor guide

Research direction
Review the current IsAnagram implementation, identify the flaw, and replace with a LINQ based solution using OrderBy and SequenceEqual or a frequency dictionary.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#LINQ
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75