aalhour/C-Sharp-Algorithms

IsAnagram logic needs to be fixed

Open

#11 opened on Aug 20, 2015

View on GitHub
 (1 comment) (0 reactions) (1 assignee)C# (5,736 stars) (1,409 forks)batch import
buggood first issue

Description

I think the IsAnagram() method doesn't work as expected. For example, it would fail for the below string combinations ("abc","bbb") or ("acdf", "bcde").

I think a simple LINQ implementation would be easy enough to implement here. If you like, I could do that and also implement unit tests for it.

Contributor guide

Tech stack
csharp
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C# basicsLINQ knowledgeunit testing familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine the IsAnagram method in the codebase. The current logic fails for cases like ('abc','bbb') and ('acdf','bcde'). A straightforward fix is to use LINQ's SequenceEqual after sorting the character arrays. Also, consider adding unit tests for these edge cases. Locate existing test files and add the new test cases.