Inconsistent return value for shortFmt
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- angularjs, javascript
- Domain
- frontend
Research direction
Find the shortFmt filter implementation in the angular-filter source code, likely in a file like lib/filters/math/shortFmt.js or similar. The fix is to ensure it always returns a string by coercing numbers under 1000 to strings. Test the change by running any existing tests for shortFmt to verify the behavior.
Written by the indexing model from the issue text.
Description
The current behavior
When given an Number less than 1000, shortFmt returns a Number. Otherwise, it returns a String.
Why is this a problem?
Consider the following case:
<span>{{ (n | shortFmt:1) || 'N/A'}}</span>
When n = 0, this will print "N/A" (Why? Because 0 is a false-y value in JS. Therefore, it evaluates the right-hand side of the "||"). I believe that most developers would expect this to print "0" instead. (Similar to the behavior of angular's number filter)
Proposed fix
When n < 1000, return n + ''. This will coerce the Number into a String.
If this seems like a reasonable behavior, then I'll go ahead and create a PR for this later today.
- Dominant language
- JavaScript
- Stars
- 2.9k
- Forks
- 319
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from a8m/angular-filter
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
a8m/angular-filter#267 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
a8m/angular-filter#260 · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
a8m/angular-filter#254 · 2 comments · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
a8m/angular-filter#250 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
a8m/angular-filter#208 · 1 comment · 1 reaction ·
All issues in a8m/angular-filter
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
TheOdinProject/curriculum#31423 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
WGBH-MLA/dream-aapb#69 ·
-
Difficulty 1/5 1-3 hours Newbie friendliness 78/100
Mintplex-Labs/anything-llm#6490 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
openlayers/ol-cesium#1364 ·