After, Before are 1-Indexed Instead of 0-indexed

Open Beginner friendly
#128 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
85/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Stale
Tech stack
angularjs, javascript
Domain
documentation

Research direction

Find the documentation for the 'after' and 'before' filters in the project's README or docs. Update the text to clearly state they are 1-indexed. Verify by checking the filter implementation in the source code to confirm the indexing behavior.

Written by the indexing model from the issue text.

Description

I would suggest a change, but this would break a lot of stuff. Therefore, I suggest changing the documentation to reflect that it's 1-indexed, as this is confusing and I thought it wasn't working (I was doing before:1 assuming it would give me the first item as a collection but it gave me nothing instead. Don't suggest "first," as I wanted a collection to run through a template and then had after:1 going through the same template)

Dominant language
JavaScript
Stars
2.9k
Forks
319
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from a8m/angular-filter

All issues in a8m/angular-filter

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.